Skip to content

doc/operator-scope: add scope tag for CRD generation#1652

Merged
hasbro17 merged 1 commit intooperator-framework:masterfrom
hasbro17:update-cluster-scope-doc
Jul 9, 2019
Merged

doc/operator-scope: add scope tag for CRD generation#1652
hasbro17 merged 1 commit intooperator-framework:masterfrom
hasbro17:update-cluster-scope-doc

Conversation

@hasbro17
Copy link
Copy Markdown
Contributor

@hasbro17 hasbro17 commented Jul 8, 2019

Description of the change:
Document the tag // +genclient:nonNamespaced for generating CRDs as cluster-scoped in the operator scope document.
Also add a line clarifying the default usage of the WATCH_NAMESPACE env in the user guide.

Motivation for the change:
Closes: #1650

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 8, 2019
@hasbro17 hasbro17 requested a review from estroz July 8, 2019 19:48
Copy link
Copy Markdown
Member

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2019
@hasbro17 hasbro17 merged commit 34edd0a into operator-framework:master Jul 9, 2019
@hasbro17 hasbro17 deleted the update-cluster-scope-doc branch July 9, 2019 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CRD scope reset to Namespaced on YAML generation

3 participants